refactor: apply future type hints style#1884
Merged
waketzheng merged 9 commits intotortoise:developfrom Feb 24, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #1884 will not alter performanceComparing Summary
|
Pull Request Test Coverage Report for Build 13408107803Details
💛 - Coveralls |
Contributor
Author
|
@henadzit Cloud you review this? |
henadzit
reviewed
Feb 17, 2025
Contributor
henadzit
left a comment
There was a problem hiding this comment.
Hey, i reviewed probably a half of this PR and left a few comments. Hopefully, I'll check out the other half in the coming days.
henadzit
reviewed
Feb 18, 2025
Contributor
henadzit
left a comment
There was a problem hiding this comment.
Left a few minor comments but apart from that I think it's good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
from __future__ import annotations:ruff check --fix --unsafe-fixes tortoise examples tests conftest.pyto reformatautoflake --remove-all-unused-imports -i -r tortoise examples tests conftest.pymake _stylemake lintto bemake style+make checktortoise/backends/base/schema_generator.py::BaseSchemaGenerator::_get_table_sqlto reduce complexity (which was complained by codacy)Motivation and Context
To improve contributing experience
How Has This Been Tested?
make ci
Checklist: