Skip to content

Conversation

@henadzit
Copy link
Contributor

@henadzit henadzit commented Feb 26, 2025

Description

Replacing PseudoColumn with Field when referencing annotations in ORDER BY because PseudoColumn doesn't add quotes.

Motivation and Context

Should fix #1899.

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #1900 will not alter performance

Comparing henadzit:fix/reserved-words-in-order-by (d5aecaa) with develop (466ddfa)

Summary

✅ 16 untouched benchmarks

@henadzit henadzit force-pushed the fix/reserved-words-in-order-by branch from 184fdb4 to d5aecaa Compare February 26, 2025 10:31
@henadzit henadzit requested a review from waketzheng February 26, 2025 10:34
@henadzit henadzit assigned abondar and unassigned abondar Feb 26, 2025
@henadzit henadzit requested a review from abondar February 26, 2025 10:36
@henadzit henadzit merged commit 587d8a0 into tortoise:develop Feb 26, 2025
8 of 9 checks passed
@coveralls
Copy link

coveralls commented Feb 26, 2025

Pull Request Test Coverage Report for Build 13541842781

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.427%

Totals Coverage Status
Change from base Build 13541386004: 0.0%
Covered Lines: 6592
Relevant Lines: 7191

💛 - Coveralls

@henadzit henadzit mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tortoise.exceptions.OperationalError: syntax error at or near "order" in 0.24.1

4 participants