Skip to content

chore: remove poetry section and default to skip poetry add test#2025

Merged
waketzheng merged 5 commits intotortoise:developfrom
waketzheng:remove-poetry-section
Feb 1, 2026
Merged

chore: remove poetry section and default to skip poetry add test#2025
waketzheng merged 5 commits intotortoise:developfrom
waketzheng:remove-poetry-section

Conversation

@waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Nov 30, 2025

Description

  1. Remove poetry section in pyproject.toml which cause poetry add git+https://github.com/tortoise/tortoise-orm to get wrong version '0.0.0' instead of '0.25.3'
  2. Only test poetry add when explicitly set env TORTOISE_TEST_POETRY_ADD to be true, because this test cost too much time and no need to run with every dialect
  3. The poetry add test requires network access, default to skip it so that we can run unittest offline

Motivation and Context

Fix wrong version and reduce ci execute time (about 1 minute)
image

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 30, 2025

Merging this PR will not alter performance

✅ 16 untouched benchmarks


Comparing waketzheng:remove-poetry-section (3367fac) with develop (fa94d12)

Open in CodSpeed

@coveralls
Copy link

coveralls commented Nov 30, 2025

Pull Request Test Coverage Report for Build 21559184136

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.005%

Totals Coverage Status
Change from base Build 21541547453: 0.0%
Covered Lines: 9839
Relevant Lines: 11192

💛 - Coveralls

@waketzheng waketzheng changed the title chore: remove poetry section and default to skip poetry add test chore: remove poetry section and default to skip poetry add test Feb 1, 2026
@waketzheng waketzheng merged commit d639e08 into tortoise:develop Feb 1, 2026
8 checks passed
@waketzheng waketzheng deleted the remove-poetry-section branch February 1, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments