You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey! Thanks for the PR. Quick question: since importing from es-toolkit/compat/func already tree-shakes and only pulls in what you need, do we really need ESM exports? What's the benefit we'd get from them? (Just asking because dual CJS/ESM packages can introduce risks like dual package hazards, so I want to make sure it's worth it.)
@raon0211 i see more clear build with esm imports. 'require' not well.
if you care about default require compability, we can make second build folder, such as compat-esm or any )
4 step to future from work experiments (ui build, d - desktop, m - mobile)
a bit clear zip size (-1.5 kb) and more effective raw size (-8.5 kb) from 'require' compat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add esm imports for compat version
Helpful for lodash migrations (like https://gist.github.com/denisx/a06fc2b518ec152d2ef631674ac87b30)