New : Pups-Overlay #62
Conversation
|
Hi @Pupariaa, thanks for submitting! |
|
|
you pushed both |
Ah, my mistake! It was a first test; I'll remove it. |
|
I deleted it! Thank you for the feedback, it wasn’t supposed to be there aha |
GabuTheDev
left a comment
GabuTheDev
left a comment
There was a problem hiding this comment.
besides the individual comments, you could minify the deps (excluding tosu's websocket).
I have a vague feeling this overlay may have been coded with the help of AI.
counters/Pups-Overlay by Puparia/deps/reconnecting-websocket.min.js
Outdated
Show resolved
Hide resolved
|
@Pupariaa ping |
|
@Pupariaa reminder |
Hi, I will work on it, I’ve had quite a few struggles at the moment. |
|
i've pinged you to resolve requested changes |
cyperdark
left a comment
cyperdark
left a comment
There was a problem hiding this comment.
another bulk of changes
| @@ -0,0 +1,952 @@ | |||
| @import url('https://fonts.googleapis.com/css2?family=Inter:wght@300;400;500;600;700&family=JetBrains+Mono:wght@400;500;600&display=swap'); | |||
There was a problem hiding this comment.
image doesnt match the rest of the mods
|
@Pupariaa pinging once again to fix requested changes |
|
|
ah shit i keep forgetting that people have a life, sorry and have fun |
- use socket.sendCommand instead of fetch for settings - remove calculateModdedStats (tosu already provides converted stats) - use beatmap.stats.*.converted directly - fix BPM to use realtime when available - remove console.log
|
I tried to fix all the highlighted issues. It may be that I forgot some |
|
i closed the one's you fixed, only 2 issues are left, feel free to fix when you free |
3 participants
Demo: https://youtu.be/tcuxGRcZfzE