New: SonataOverlay

[ParaliyzedEvo]

This overlay is a fork (and maintained version) of the original SonotaOverlay made by HosizoraN (using archive.org links due to them deleting the accounts). Only reason I have this is me having this overlay for a few years and using it (via tosu) for videos and streams and problems arose with it and I fixed them.

Demo vid of the overlay in use (along with other ones): https://youtu.be/jzOYvq27S3U

Repo: https://github.com/ParaliyzedEvo/SonataOverlay

[KotRikD]

Just a few words, that currently making this overlay is not possible to merge:

• Licensing? Do you have permission from HosizoraN to upload this overlay here?
• Public proxy url aren't permitted to bypass osu! api CORS due to security reasons
• You have put publicly OSU_CLIENT_SECRET, I suggest to change it ASAP, because it can give you ban in bad hands

[ParaliyzedEvo]

Just a few words, that currently making this overlay is not possible to merge:

* Licensing? Do you have permission from HosizoraN to upload this overlay here?

* Public proxy url aren't permitted to bypass osu! api CORS due to security reasons

* You have put publicly `OSU_CLIENT_SECRET`, I suggest to change it ASAP, because it can give you ban in bad hands

holy, i didnt mean to upload this version of the sonata overlay at all with all my keys and auth 😭😭😭. and looks like i choose the wrong license, cuz technically with the license that HosizoraN used in the repo before it was deleted, it said as long as I credit the original creator (from what ive known about the license) i should be able to upload it here. also for cors, for some reason it kept getting blocked for some reason and said f it, imma js use my own private proxy that i host, is that not allowed?

[GabuTheDev]

There can also be a whole debate on if you are really the one to credit as creator.

If this is a fork, means you brought changes to the main code, if not, it's just a reupload.
You mentioned you're only "maintaining" it, which changes your role to more of a maintainer and publisher rather than owner...

im unsure here

[ParaliyzedEvo]

There can also be a whole debate on if you are really the one to credit as creator.

If this is a fork, means you brought changes to the main code, if not, it's just a reupload. You mentioned you're only "maintaining" it, which changes your role to more of a maintainer and publisher rather than owner...

im unsure here

@GabuTheDev Yes this is indeed a fork (technically, as the original repo is gone) as I've edited some of the index.html to my liking. I'm also making changes on how it calls osu api as the original way got broken. My original patch isn't permitted here, so rn I'm trying to switch it over to tosu websocket, license and original name of the overlay is the same. I've only said I'm maintaining it because well, technically I am (?) since I'm fixing things and patching broken things the creator didn't, in the main code.

[ParaliyzedEvo]

@KotRikD Making the switch over to tosu websocket, I'll prolly finish up by tmw

[KotRikD]

Just a few words, that currently making this overlay is not possible to merge:

* Licensing? Do you have permission from HosizoraN to upload this overlay here?

* Public proxy url aren't permitted to bypass osu! api CORS due to security reasons

* You have put publicly `OSU_CLIENT_SECRET`, I suggest to change it ASAP, because it can give you ban in bad hands

holy, i didnt mean to upload this version of the sonata overlay at all with all my keys and auth 😭😭😭. and looks like i choose the wrong license, cuz technically with the license that HosizoraN used in the repo before it was deleted, it said as long as I credit the original creator (from what ive known about the license) i should be able to upload it here. also for cors, for some reason it kept getting blocked for some reason and said f it, imma js use my own private proxy that i host, is that not allowed?

Ahhh, you're blocked because of osu! CORS that doesn't allows random pages to access osu api from browser. Think about this like random person can access private user data with credentials header and leak all data :xd

And yeah, proxies are don't allowed too. Is it special kind of data you "need" to make this overlay possible? Like I really think that tosu really implements big amount of osu-api like data.

[ParaliyzedEvo]

Just a few words, that currently making this overlay is not possible to merge:

* Licensing? Do you have permission from HosizoraN to upload this overlay here?

* Public proxy url aren't permitted to bypass osu! api CORS due to security reasons

* You have put publicly `OSU_CLIENT_SECRET`, I suggest to change it ASAP, because it can give you ban in bad hands

holy, i didnt mean to upload this version of the sonata overlay at all with all my keys and auth 😭😭😭. and looks like i choose the wrong license, cuz technically with the license that HosizoraN used in the repo before it was deleted, it said as long as I credit the original creator (from what ive known about the license) i should be able to upload it here. also for cors, for some reason it kept getting blocked for some reason and said f it, imma js use my own private proxy that i host, is that not allowed?

Ahhh, you're blocked because of osu! CORS that doesn't allows random pages to access osu api from browser. Think about this like random person can access private user data with credentials header and leak all data :xd

And yeah, proxies are don't allowed too. Is it special kind of data you "need" to make this overlay possible? Like I really think that tosu really implements big amount of osu-api like data.

@KotRikD I only needed the proxy to get global leaderboards and user top plays, which I dont think tosu provides that unless I'm wrong, but yea anyways im starting to test on websocket so hopefully it works out

[ParaliyzedEvo]

@KotRikD using a local proxy is fine right? obv the user still needs to run it, but doing this instead of a public proxy should work right to get the data needed for my overlay? oh and should include the original unbundled file also or is js the binaries fine?

[GabuTheDev]

Had a general look over. This is a pretty complex overlay, the most complex so far that tosu could have.
There are a lot of things that need to change.

[ParaliyzedEvo]

@GabuTheDev ping

[GabuTheDev]

Went again through the files, light review.

[ParaliyzedEvo]

@GabuTheDev ping

[GabuTheDev]

Without actual testing, code lgtm.

[KotRikD]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18502de9a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[ParaliyzedEvo]

@KotRikD ping

[KotRikD]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3381404432

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[ParaliyzedEvo]

@KotRikD ping

[KotRikD]

@GabuTheDev Check please