Fix RND-463. #247
Fix RND-463. #247
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Compose recomposition issues and improves the visual styling of the first-run conference selector dialog.
- Wraps the single-conference auto-selection in
LaunchedEffectto prevent repeated execution during recomposition - Replaces manual
Columnstyling withSurfacecomposable for proper Material Design theming - Removes unused imports that were added but not utilized
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MainComposeView.kt | Wraps single-conference selection in LaunchedEffect to ensure it only executes once and uses first() instead of get(0) |
| FirstRunConferenceSelector.kt | Refactors dialog styling to use Surface composable and adds explicit text color for better theming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| import androidx.compose.foundation.background | ||
| import androidx.compose.foundation.clickable | ||
| import androidx.compose.foundation.isSystemInDarkTheme |
There was a problem hiding this comment.
The isSystemInDarkTheme import is unused and should be removed. The code uses MaterialTheme.colorScheme for theming instead.
| import androidx.compose.foundation.isSystemInDarkTheme |
| import androidx.compose.ui.unit.dp | ||
| import androidx.compose.ui.window.Dialog | ||
| import co.touchlab.droidcon.domain.entity.Conference | ||
| import co.touchlab.droidcon.ui.theme.DroidconTheme |
There was a problem hiding this comment.
The DroidconTheme import is unused and should be removed. The dialog relies on MaterialTheme which is already provided by the parent composable hierarchy.
| import co.touchlab.droidcon.ui.theme.DroidconTheme |
Looks Good |
KevinSchildhorn
left a comment
KevinSchildhorn
left a comment
There was a problem hiding this comment.
Just doing this as a test
No description provided.