feat: Implement Shift-click range selection for keywords#293
Open
abhranil26 wants to merge 2 commits intotowfiqi:mainfrom
Open
feat: Implement Shift-click range selection for keywords#293abhranil26 wants to merge 2 commits intotowfiqi:mainfrom
abhranil26 wants to merge 2 commits intotowfiqi:mainfrom
Conversation
This commit introduces the ability to select a range of keywords by holding down the Shift key while clicking.
Key changes:
- Modified `components/keywords/KeywordsTable.tsx`:
- The `selectKeyword` function now accepts an optional mouse event.
- If the Shift key is pressed during a click, it identifies the last selected keyword and the currently clicked keyword.
- All keywords between these two (inclusive) are then selected. Existing selections outside this range are preserved.
- Updated `components/keywords/Keyword.tsx`:
- The `onClick` handler for the keyword selection checkbox now passes the mouse event to the `selectKeyword` function.
- Added `data-testid` attributes to keyword rows and checkboxes to facilitate testing.
- Added unit tests in `__tests__/components/KeywordsTable.test.tsx`:
- Created new test suite for `KeywordsTable`.
- Implemented comprehensive tests covering various Shift-click scenarios, including forward, reverse, and disjointed selections, as well as interactions with normal clicks.
This enhancement improves the usability of keyword selection, allowing you to more efficiently manage large lists of keywords.
This commit corrects various linting errors and import path issues identified in the previous commit.
Corrections in `__tests__/components/KeywordsTable.test.tsx`:
- Resolved critical path errors for `KeywordType`, `SettingsType`, and `DomainType` by updating import paths to `../../types`.
- Added `displayName` to all mocked functional components (Icon, Keyword, KeywordDetails, KeywordFilter, Modal, Toaster, FixedSizeList) to prevent 'missing display name' warnings.
- Fixed code style issues:
- Reformatted long lines in `mockKeywords` data to improve readability and adhere to character limits.
- Added missing trailing commas.
- Removed excessive blank lines.
- Corrected spacing in the `react-hot-toast` mock.
- Ensured object properties in `mockDomain` and `mockSettings` are on new lines for better formatting.
Correction in `components/keywords/KeywordsTable.tsx`:
- Removed unnecessary blank line padding within the `selectKeyword` function to resolve a 'Block must not be padded by blank lines' error.
These changes ensure the codebase adheres to linting standards and resolves import errors, improving code quality and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to select a range of keywords by holding down the Shift key while clicking.
Key changes:
components/keywords/KeywordsTable.tsx:selectKeywordfunction now accepts an optional mouse event.components/keywords/Keyword.tsx:onClickhandler for the keyword selection checkbox now passes the mouse event to theselectKeywordfunction.data-testidattributes to keyword rows and checkboxes to facilitate testing.__tests__/components/KeywordsTable.test.tsx:KeywordsTable.This enhancement improves the usability of keyword selection, allowing you to more efficiently manage large lists of keywords.