Fix Docker gateway IP detection for newer Docker versions #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve gateway IP detection in get_gateway_ip() to handle both legacy and newer Docker API formats: - Try legacy NetworkSettings.Gateway first for backwards compatibility - Fall back to Networks section for newer Docker versions - Iterate through all networks to find any available gateway - Maintain "0.0.0.0" fallback for cases where no gateway is found This resolves issues where newer Docker versions store network information in a different structure than the legacy format. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve gateway IP detection in get_gateway_ip() to handle both legacy and newer Docker API formats:
This resolves issues where newer Docker versions store network information in a different structure than the legacy format.
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]