automatically resize images after showing and when size changes #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@wentasah, this is a trivial change to have the images fill the window, but since you are the author of the original code your comments would be appreciated. |
wentasah
approved these changes
Jul 1, 2025
Contributor
wentasah
left a comment
wentasah
left a comment
There was a problem hiding this comment.
Looks good to me.
Initially, I expected it to just shrink larger images, but it also enlarges smaller images. This is probably useful too.
I was also afraid that the lambda can be added multiple times to the hook, but emacs seems clever enough to not duplicate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this drops support for all Emacs versions before 29.1, which was released 2023-07-30. I think that is acceptable, but if someone desperately needs those, please comment and we can discuss it.