Skip to content

Clean up project filename code, fix bugs, make it public API. #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tpapp merged 1 commit into from
Jul 19, 2025
Merged

Clean up project filename code, fix bugs, make it public API. #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions julia-repl.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,11 +854,11 @@ name), separated by dots, as a list."
(with-current-buffer (julia-repl-inferior-buffer) (cd directory)))
(warn "buffer not associated with a file")))

(cl-defun julia-repl--find-projectfile (&optional (filename (buffer-file-name)))
"Find a project file in the parent directories of the filename "
(when filename
(cl-flet ((find-projectfile (filename)
(locate-dominating-file (buffer-file-name) filename)))
(cl-defun julia-repl-find-projectfile (&optional (start-filename (buffer-file-name)))
"Find a project file in the parent directories of the `start-filename'. When no such file is found, return `nil' "
(when start-filename
(cl-flet ((find-projectfile (project-filename)
(locate-dominating-file start-filename project-filename)))
(or (find-projectfile "Project.toml")
(find-projectfile "JuliaProject.toml")))))

Expand All @@ -871,7 +871,7 @@ When called with a prefix argument, activate the home project."
(progn
(message "activating home project")
(julia-repl--send-string "import Pkg; Pkg.activate()"))
(if-let ((projectfile (julia-repl--find-projectfile)))
(if-let ((projectfile (julia-repl-find-projectfile)))
(progn
(message "activating %s" projectfile)
(julia-repl--send-string
Expand Down
Loading