[CMake][NFC] Disable mismatched-new-delete warning in GCC #19
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning triggers for the overloads for operator new/delete in BumpAllocator, because the BumpAllocator class is templated with the SlabSize. GCC does select the correct overload of operator new/delete, but produces a warning. Since we build with -Wall -Werror this results in a compile error. We are in the process of reporting this to GCC, but for now let's disable the warning.
Contributor
Author
|
Here is a minimal reproducer for the potential GCC bug: |
marcauberer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning triggers for the overloads for operator new/delete in BumpAllocator, because the BumpAllocator class is templated with the SlabSize. GCC does select the correct overload of operator new/delete, but produces a warning. Since we build with -Wall -Werror this results in a compile error. We are in the process of reporting this to GCC, but for now let's disable the warning.