Expand betting strategy test coverage #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive tests for betting strategies to support future strategy composition features: Priority 1: Add missing tests - Add 5 tests for minPassLinePlaceSixEight strategy (previously untested) - Export placeSixEightUnlessPoint for testability Priority 2: Cover all game states - Test all points (4, 5, 6, 8, 9, 10) with correct odds multiples - Add full roll cycle tests (comeout → point set → neutral rolls → seven out) Priority 3: Test composition properties - Add invariant tests (bets.new accuracy, immutability, idempotence) - Add composition contract tests (composability, order independence, error handling) Test count increased from 13 to 31 tests for betting strategies All tests passing with 84.37% statement coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive tests for betting strategies to support future strategy
composition features:
Priority 1: Add missing tests
Priority 2: Cover all game states
Priority 3: Test composition properties
Test count increased from 13 to 31 tests for betting strategies
All tests passing with 84.37% statement coverage