configure.ac: Add Wformat-security to Wformat check

[bbhtt]

Same change as tpm2-software/tpm2-tools@52ac6af

This became fatal with newer automake/autoconf

checking whether byte ordering is bigendian... no
checking whether the C compiler accepts -Wall... yes
checking whether the C compiler accepts -Wextra... yes
checking whether the C compiler accepts -Wformat... yes
checking whether the C compiler accepts -Wformat-security... no
configure: error: Cannot enable -Wformat-security, consider configuring with --disable-hardening

[williamcroberts]

@bbhtt I'll take this, can you add a signed off to your commit and re-push? I'll probably start the RC cycle without this and then I'll merge it if you sign it off in the next week before a release.

[williamcroberts]

I actually need this now... so moved: #904

[bbhtt]

If the ci here wasn't so broken I'd have seen the dco workflow failing and added it then. The nice thing to do when taking other's patches is to preserve authorship.

[williamcroberts]

If the ci here wasn't so broken I'd have seen the dco workflow failing and added it then.

The DCO check is it's own thing so it's not even polluted by the failing CI test scripts:

The nice thing to do when taking other's patches is to preserve authorship.

I can't sign off the DCO for you, I gave you attribution in the commit message for my follow up. I had no idea how quickly you could turn it around, and couldn't hold up the release any longer, my apologies. I do appreciate your comments back, at least now I know in the future you're pretty quick with responses.

[bbhtt]

If you need it fast maybe visit the open PRs in your repo more often. This was sitting here for over 2 months without any review and suddenly you need it "right now" and can't wait a day let alone more than 1 hour meanwhile I was waiting for 2 months...very fair.

A "related to" link to the PR is not attribution.

[williamcroberts]

If you need it fast maybe visit the open PRs in your repo more often. This was sitting here for over 2 months without any review and suddenly you need it "right now" and can't wait a day let alone more than 1 hour meanwhile I was waiting for 2 months...very fair.

A "related to" link to the PR is not attribution.

Sorry our funding was pulled and we're all keeping the lights on in our spare time. We've made multiple calls to ask for new maintainers to help, and I didn't see you step up. What you didn't see was the person that was patiently working with me for over a year to get what he wants and assisted in getting the release process started and fixing our CI.

Your lack of following our contribution guidelines and missing the DCO is not my problem.