pcks11: use bytes.decode on stderr#911
Merged
williamcroberts merged 1 commit intotpm2-software:masterfrom Dec 18, 2025
Merged
Conversation
Before: ``` RuntimeError: Could not execute tpm2_create: b'WARNING:esys:src/tss2-esys/api/Esys_Create.c:399:Esys_Create_Finish() Received TPM Error \nERROR:esys:src/tss2-esys/api/Esys_Create.c:134:Esys_Create() Esys Finish ErrorCode (0x0000098e) \nERROR: Esys_Create(0x98E) - tpm:session(1):the authorization HMAC check failed and DA counter incremented\nERROR: Unable to run /nix/store/n9b9hqgmw2f08f8kdcp41pfbs06p9b8v-tpm2-tools-5.7/bin/tpm2_create\n' ``` After: ``` RuntimeError: Could not execute tpm2_create: WARNING:esys:src/tss2-esys/api/Esys_Create.c:399:Esys_Create_Finish() Received TPM Error ERROR:esys:src/tss2-esys/api/Esys_Create.c:134:Esys_Create() Esys Finish ErrorCode (0x0000098e) ERROR: Esys_Create(0x98E) - tpm:session(1):the authorization HMAC check failed and DA counter incremented ERROR: Unable to run /nix/store/n9b9hqgmw2f08f8kdcp41pfbs06p9b8v-tpm2-tools-5.7/bin/tpm2_create ``` Signed-off-by: Philip Taron <philip.taron@gmail.com>
philiptaron
force-pushed
the
stderr-decode
branch
from
37a5dac to
31aac0c
Compare
Contributor
Author
|
@williamcroberts mind taking a look at this simple PR? |
williamcroberts
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
From what I can tell, these lines date before the Python 3 transition.