tpm2_getekcertificate: add option --x509-trunc #3483
Merged
+35
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New option to handle x509 DER with trailing data ST micro's ST33HTPHF2ENIST TPM creates NIST P-256 ECC and RSA EK certificates with 0xff data padded to a fixed 1600 bytes length. The option "--x509-trunc" or "-t" parses the output of "nv_read" with a X509 parser and truncates the trailing data. This makes the output formate more accessable to GOLANG's X509.ParseCertificate(). Details about this issue can be found at: tpm2-software#3474 Signed-off-by: Samuel Cheng <samuelogre@gmail.com>
Add new option "-t", "--x509-trunc" to man/tpm2_getekcertificate.1.md Signed-off-by: Samuel Cheng <samuelogre@gmail.com>
Contributor
Author
|
@JuergenReppSIT Sorry, but I've already signed-off both commits, I don't get why the DCO test failed. |
Member
|
@saurontech I also don't get why the DCO test failed. Both commits the "Signed-of-by" looks right. Thank you for updating the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option to handle x509 DER with trailing data
ST micro's ST33HTPHF2ENIST TPM creates NIST P-256 ECC and RSA EK certificates with 0xff data padded to a fixed 1600 bytes length. The option "--x509-trunc" or "-t" parses the output of "nv_read" with a X509 parser and truncates the trailing data. This makes the output formate more accessable to GOLANG's X509.ParseCertificate(). Details about this issue can be found at: #3474
Also, added the documentation to ./man/tpm2_getekcertificate.1.md mentioned at : #3481 (comment)
Sorry to mess up the original PR by missing the --signed-off in a commit.
I'll be more careful next time.
Signed-off-by: Samuel Cheng samuelogre@gmail.com