tpm2_makecredential: Fix usage of name parameter.#3519
Merged
JuergenReppSIT merged 1 commit intotpm2-software:masterfrom Oct 30, 2025
Merged
Conversation
cplappert
approved these changes
Oct 29, 2025
cplappert
requested changes
Oct 29, 2025
man/tpm2_makecredential.1.md
Outdated
| The secret which will be protected by the key derived from the random seed. It can be specified as a file or passed from stdin. | ||
|
|
||
| * **-n**, **\--name**=_FILE_: | ||
| * **-n**, **\--name**_FILE\_OR\_HEX_: |
Member
There was a problem hiding this comment.
Please add back the equal sign.
The man page for tpm2_makecredential states that the -name parameter can be a file. However, a hex string of the name is expected. Similar to the procedure used with tpm2_certifycreation, a file with the name or a hex string can now be passed. Fixes: tpm2-software#3274 Signed-off-by: Juergen Repp <juergen_repp@web.de>
JuergenReppSIT
force-pushed
the
fix-name-param-makecredential
branch
from
3da556f to
f83764d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The man page for tpm2_makecredential states that the -name parameter can be a file. However, a hex string of the name is expected. Similar to the procedure used with tpm2_certifycreation, a file with the name or a hex string can now be passed.
Fixes: #3274