tools: Fix clang tidy errors. #3531
Merged
+58
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JuergenReppSIT
commented
Dec 1, 2025
JuergenReppSIT
commented
- tools: Fix wrong type usage of enums.
- lib/tpm2_kdfa.c: Fix pragma statement.
- configure.ac Fix compilation with CC=clang
enums used as bitmask are now declared as <enum_type>_enum the bitmaks is now declared with typedef unsigned int <enum_type> Signed-off-by: Juergen Repp <[email protected]>
The pragma statement to deactivate optimization for gcc produced an error when clang is used with -Werror. Signed-off-by: Juergen Repp <[email protected]>
AndreasFuchsTPM
approved these changes
Dec 3, 2025
compilation was not possible with -Werror if clang is used. Now warnings from unknown -W flags are supressed. Signed-off-by: Juergen Repp <[email protected]>
JuergenReppSIT
force-pushed
the
fix-clang-tidy2
branch
from
7ecd848 to
84a676b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.