add gm algorithm support. #297
Open
+233
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalvdans
reviewed
Dec 18, 2025
kalvdans
left a comment
kalvdans
left a comment
There was a problem hiding this comment.
Some comments, I'm not very familiar with the source code yet, feel free to ignore them!
kalvdans
reviewed
Dec 20, 2025
kalvdans
reviewed
Dec 20, 2025
chench246
force-pushed
the
master
branch
3 times, most recently
from
a39240c to
5795ccf
Compare
kalvdans
reviewed
Dec 25, 2025
Signed-off-by: chench246 <chench246@hotmail.com>
kalvdans
approved these changes
Jan 29, 2026
kalvdans
left a comment
kalvdans
left a comment
There was a problem hiding this comment.
The patch looks good to me now! I don't have merge rights though. Thanks for your patience!
Author
|
@AndreasFuchsTPM @williamcroberts Would you mind taking a look at this PR and sharing your feedback? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add gm algorithm support.