Add support for Snowflake CLI alongside SnowSQL #213
+93
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add g:db_adapter_snowflake_use_cli variable to toggle between tools - Switch to long cli args to simplify command invocation (same args for both) - Switch to csv completion for the same reason (snow cli doesn't support tsv) - Keep SnowSQL as default for backward compatibility - Add tests to ensure functionality Relates to tpope#174 Signed-off-by: Jonas-Taha El Sesiy <github@elsesiy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using the current Snowflake implementation via
snowsqlwith mandatory SSO, I found it barely usable given the constant browser interrupts. Hence, I implemented support forsnowCLI which was also mentioned in #174 (comment) with the same motivation.Relates to #174
Note: I have yet to thoroughly test it but wanted to open it up for conversation already in case it requires some bigger refactoring.