Support clipboard_provider for GBrowse!#2447
Open
na0x2c6 wants to merge 1 commit intotpope:masterfrom
Open
Conversation
The `has('clipboard')` check in `s:BrowserOpen()` does not account for
`clipboard-providers`, which was introduced in Vim v9.1.2081. As
a result, `:GBrowse!` unintentionally skips copying the URL to the
clipboard when clipboard-providers is configured.
This commit adds a check for `has('clipboard_provider')` to fix this
behavior. According to the documentation, `has('unnamedplus')` should
detect this, but it did not work in actual environment. Specifically,
the check logic focuses on avoiding to throw `E354: Invalid register
name: '+'`.
Link: https://vimhelp.org/eval.txt.html#clipboard-providers
Link: vim/vim@67860ef
Resolves: tpope#2446
Advised-by: Tim Pope <code@tpope.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I opened a PR to fix #2446
Thanks.
The
has('clipboard')check ins:BrowserOpen()does not account forclipboard-providers, which was introduced in Vim v9.1.2081. As a result,:GBrowse!unintentionally skips copying the URL to the clipboard when clipboard-providers is configured.This commit adds a check for
has('clipboard_provider')to fix this behavior. According to the documentation,has('unnamedplus')should detect this, but it did not work in actual environment. Specifically, the check logic focuses on avoiding to throwE354: Invalid register name: '+'.Link: https://vimhelp.org/eval.txt.html#clipboard-providers
Link: vim/vim@67860ef
Resolves: #2446
Advised-by: Tim Pope code@tpope.net