Skip to content

Conversation

tpvasconcelos
Copy link
Owner

@tpvasconcelos tpvasconcelos commented Oct 28, 2024

Description

Related issues

#88

PR check list

  • Read the contributing guidelines.
    • You don't have to read the whole thing, but it's a good idea to skim it. And definitely take a look at it if you're experiencing any issues getting your local environment up and running.
  • Provided the relevant details in the PR's description.
  • Referenced relevant issues in the PR's description.
  • Added tests for all my changes.
    • The CI will fail unless 100% of all new code is covered by the tests.
  • Updated the docs for relevant changes.
    • New modules (or renamed ones) are included in docs/api/internal/.
    • New public functions/classes/variables are documented in docs/api/index.rst.
    • Added the appropriate versionadded, versionchanged, or deprecated directives to docstrings.
      • The version should be the next release version, which you can infer by bumping the minor version in MAJOR.MINOR.PATCH (e.g., if the current version is 0.2.3, the next release will be 0.3.0).
  • Changes are documented in docs/reference/changelog.md.
    • Please try to follow the conventions laid out in the file. In doubt, just ask!
  • Consider granting push permissions to your PR's branch, so maintainers can help you out if needed.
  • The CI check are all passing, or I'm working on fixing them!
  • I have reviewed my own code! 🤠

📚 Documentation preview 📚: https://ridgeplot--267.org.readthedocs.build/en/267/

@tpvasconcelos tpvasconcelos linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link

⚠️ Missing changelog entry ⚠️

Please add an entry to the changelog in docs/reference/changelog.md for this PR.
The entry should be in the following format:

- Description of the change ({gh-pr}`267`)

If you don't think a changelog entry is necessary for this change, you can add a skip news label to this PR.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4cc1f63) to head (09e09f5).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #267   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          648       648           
  Branches        82        82           
=========================================
  Hits           648       648           
Flag Coverage Δ
combined-src 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpvasconcelos
Copy link
Owner Author

tpvasconcelos commented Oct 29, 2024

Let's wait for sphinx-gallery/sphinx-gallery#1398 (sphinx-gallery/sphinx-gallery#1397) to be merged and released

@tpvasconcelos tpvasconcelos marked this pull request as ready for review December 24, 2024 01:50
@tpvasconcelos tpvasconcelos marked this pull request as draft December 24, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Render Plotly graphs in Sphinx documentation

1 participant