Skip to content

Rename LowerCaseModel to FlatCaseModel, as the naming convention is correctly called flat case #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tr4nt0r merged 1 commit into from
Nov 9, 2025
Merged

Rename LowerCaseModel to FlatCaseModel, as the naming convention is correctly called flat case #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/pythonxbox/api/provider/userstats/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from pythonxbox.common.models import LowerCaseModel, PascalCaseModel
from pythonxbox.common.models import FlatCaseModel, PascalCaseModel


class GeneralStatsField:
Expand All @@ -17,7 +17,7 @@ class Properties(PascalCaseModel):
display_name: str | None = None


class Stat(LowerCaseModel):
class Stat(FlatCaseModel):
group_properties: GroupProperties | None = None
xuid: str
scid: str
Expand All @@ -27,18 +27,18 @@ class Stat(LowerCaseModel):
properties: Properties


class StatListsCollectionItem(LowerCaseModel):
class StatListsCollectionItem(FlatCaseModel):
arrange_by_field: str
arrange_by_field_id: str
stats: list[Stat]


class Group(LowerCaseModel):
class Group(FlatCaseModel):
name: str
title_id: str | None = None
statlistscollection: list[StatListsCollectionItem]


class UserStatsResponse(LowerCaseModel):
class UserStatsResponse(FlatCaseModel):
groups: list[Group] | None = None
statlistscollection: list[StatListsCollectionItem]
8 changes: 4 additions & 4 deletions src/pythonxbox/common/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
from pydantic.alias_generators import to_camel, to_pascal


def to_lower(string: str) -> str:
return string.replace("_", "")
def to_flat(string: str) -> str:
return string.lower().replace("_", "")


class PascalCaseModel(BaseModel):
Expand All @@ -20,7 +20,7 @@ class CamelCaseModel(BaseModel):
)


class LowerCaseModel(BaseModel):
class FlatCaseModel(BaseModel):
model_config = ConfigDict(
arbitrary_types_allowed=True, populate_by_name=True, alias_generator=to_lower
arbitrary_types_allowed=True, populate_by_name=True, alias_generator=to_flat
)
Loading