-
-
Notifications
You must be signed in to change notification settings - Fork 55
Add new translations for block entity culling #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds three Spanish (Argentina) localization entries for EntityCulling: a category title key and block-entity frustum culling label plus tooltip, appended to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/resources/assets/entityculling/lang/es_ar.json(2 hunks)
🧰 Additional context used
🪛 Biome (2.1.2)
src/main/resources/assets/entityculling/lang/es_ar.json
[error] 23-23: expected , but instead found "text.entityculling.blockEntityFrustumCulling"
Remove "text.entityculling.blockEntityFrustumCulling"
(parse)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (1)
src/main/resources/assets/entityculling/lang/es_ar.json (1)
1-25: Verify translation consistency and completeness.While the new translations appear well-formed Spanish (Argentina) localization, please verify:
- That the key names match their counterparts in other language files (e.g.,
en_us.json)- That the new keys (
blockEntityFrustumCullingand related category title) are actually used elsewhere in the codebaseRun the following script to verify that the new translation keys are referenced in the codebase:
Sorry, I was missing one comma.
|
Texaliuz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I was missing one comma.



No description provided.