Bugfix: Fix/forward type config #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like this has unrelated commit. |
rossigee
force-pushed
the
fix/forward-type-config
branch
from
cd3fcc1 to
5622ee6
Compare
Author
|
Oops. Fixed. |
tananaev
reviewed
Aug 21, 2025
- Update forward configuration to use proper type field - Improve configuration schema structure for better compatibility - Add configurable probe settings for deployment flexibility
rossigee
force-pushed
the
fix/forward-type-config
branch
from
63aedfd to
d94208a
Compare
Author
|
@filippolmt - is this one of interest? |
filippolmt
reviewed
Dec 1, 2025
Comment on lines
+263
to
+264
| {{- if .Values.traccar.forward.type }} | ||
| <entry key='forward.type'>{{ .Values.traccar.forward.type }}</entry> |
Contributor
There was a problem hiding this comment.
Suggested change
| {{- if .Values.traccar.forward.type }} | |
| <entry key='forward.type'>{{ .Values.traccar.forward.type }}</entry> | |
| {{- $type := .Values.traccar.forward.type | default "url" -}} | |
| {{- $allowed := list "url" "json" "amqp" "kafka" "mqtt" "redis" "wialon" -}} | |
| {{- if not (has $t $allowed) }} | |
| {{- fail (printf "forward.type '%s' is invalid. Allowed values: %v" $t $allowed) -}} | |
| {{- end }} | |
| <entry key='forward.type'>{{ $type }}</entry> | |
| {{- end }} |
Contributor
There was a problem hiding this comment.
I would probably do it like this.
P.S. I haven’t tested it, these are just suggestions.
Anyway, even if I modified it, I don’t have the power to approve and merge your PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32