fix(langchain): Added new method for fetching model name from association metadata (#3237)

Co-authored-by: Nir Gazit <[email protected]>

Author: 2getsandesh

packages/opentelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/callback_handler.py

@@ -37,6 +37,7 @@
     SpanHolder,
     _set_span_attribute,
     extract_model_name_from_response_metadata,
+    _extract_model_name_from_association_metadata,
     set_chat_request,
     set_chat_response,
     set_chat_response_usage,
@@ -508,6 +509,9 @@ def on_llm_end(
                 _set_span_attribute(span, GEN_AI_RESPONSE_ID, id)
         if model_name is None:
             model_name = extract_model_name_from_response_metadata(response)
+        if model_name is None and hasattr(context_api, "get_value"):
+            association_properties = context_api.get_value("association_properties") or {}
+            model_name = _extract_model_name_from_association_metadata(association_properties)
         token_usage = (response.llm_output or {}).get("token_usage") or (
             response.llm_output or {}
         ).get("usage")

packages/opentelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/span_utils.py

@@ -368,6 +368,11 @@ def extract_model_name_from_response_metadata(response: LLMResult) -> str:
                 and (model_name := generation.message.response_metadata.get("model_name"))
             ):
                 return model_name
+
+
+def _extract_model_name_from_association_metadata(metadata: Optional[dict[str, Any]] = None) -> str:
+    if metadata:
+        return metadata.get("ls_model_name") or "unknown"
     return "unknown"
 
 

packages/opentelemetry-instrumentation-langchain/tests/cassettes/test_agents/test_agents.yaml

@@ -151,5 +151,4 @@ def vcr_config():
     return {
         "filter_headers": ["authorization", "x-api-key"],
         "filter_body": ["api_key"],
-        "ignore_hosts": ["api.hub.langchain.com", "api.smith.langchain.com"],
     }

packages/opentelemetry-instrumentation-langchain/tests/cassettes/test_agents/test_agents_with_events_with_content.yaml

@@ -119,7 +119,7 @@ def test_agents_with_events_with_content(
             "content": "",
             "tool_calls": [
                 {
-                    "id": "call_vZSljoj56JmSCeTYR9UgYkdK",
+                    "id": "call_jb8sWc3LhC4ZZn9Ma9E2QoS4",
                     "function": {
                         "name": "tavily_search_results_json",
                         "arguments": {"query": "OpenLLMetry"},
@@ -137,7 +137,7 @@ def test_agents_with_events_with_content(
         "message": {"content": ""},
         "tool_calls": [
             {
-                "id": "call_vZSljoj56JmSCeTYR9UgYkdK",
+                "id": "call_jb8sWc3LhC4ZZn9Ma9E2QoS4",
                 "function": {
                     "name": "tavily_search_results_json",
                     "arguments": {"query": "OpenLLMetry"},
@@ -198,7 +198,7 @@ def test_agents_with_events_with_no_content(
     }
 
     logs = log_exporter.get_finished_logs()
-    assert len(logs) == 15
+    assert len(logs) == 8
     assert all(
         log.log_record.attributes.get(GenAIAttributes.GEN_AI_SYSTEM) == "langchain"
         for log in logs
@@ -217,7 +217,7 @@ def test_agents_with_events_with_no_content(
         {
             "tool_calls": [
                 {
-                    "id": "call_vZSljoj56JmSCeTYR9UgYkdK",
+                    "id": "call_h7poF0eyI0elJPMut3w8QcHi",
                     "function": {"name": "tavily_search_results_json"},
                     "type": "function",
                 }
@@ -232,7 +232,7 @@ def test_agents_with_events_with_no_content(
         "message": {},
         "tool_calls": [
             {
-                "id": "call_vZSljoj56JmSCeTYR9UgYkdK",
+                "id": "call_h7poF0eyI0elJPMut3w8QcHi",
                 "function": {"name": "tavily_search_results_json"},
                 "type": "function",
             }