chore: migrate skeleton, image, and accessible icon components to vanilla-extract #5115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gndz07
force-pushed
the
chore/migrate-skeleton-img-icon
branch
from
d071b6c to
06c5850
Compare
gndz07
force-pushed
the
chore/migrate-skeleton-img-icon
branch
from
06c5850 to
7a6f9b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the three components to vanilla-extract.
Side note about AccessibleIcon, it's a simple wrapper of an existing Radix component, so there is no difference between the 2 versions. But I keep a file named
AccessibleIcon.vanilla.tsxto keep it uniform with the other components' pattern.Some work done on the guides and documentation to update info and/or simplify the structure of the documents.