Skip to content

feat: add tests + handle TTL #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add tests + handle TTL #65

wants to merge 2 commits into from

Conversation

darkweaver87
Copy link
Contributor

This PR adds tests + add TTLs in responses

@darkweaver87 darkweaver87 added the kind/enhancement a new or improved feature. label Jan 9, 2025
@ldez
Copy link
Contributor

ldez commented Jan 9, 2025 •
edited
Loading

Go uses tab, not spaces, you should reformat the code with gofmt -w .

@emilevauge
Copy link
Member

Should we close this one or leave it open @darkweaver87 ?

@darkweaver87
Copy link
Contributor Author

darkweaver87 commented Jun 3, 2025 •
edited
Loading

@emilevauge, I forgot it honestly. I'll spend few minutes to update it in the coming days because it should be beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contributor/waiting-for-corrections kind/enhancement a new or improved feature. status/2-needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darkweaver87 @ldez @emilevauge