Skip to content

Comments

fix: type of tracing.sampleRate #1648

Open
diofeher wants to merge 5 commits intotraefik:masterfrom
diofeher:patch-1
Open

fix: type of tracing.sampleRate #1648
diofeher wants to merge 5 commits intotraefik:masterfrom
diofeher:patch-1

Conversation

@diofeher
Copy link

@diofeher diofeher commented Feb 3, 2026

sampleRate: # @schema type:[number, null]; minimum:0; maximum:1

This is only a docs change.

What does this PR do?

Motivation

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

@mloiseleur mloiseleur changed the title Fix type of tracing.sampleRate Fix type of tracing.sampleRate Feb 13, 2026
@mloiseleur mloiseleur changed the title Fix type of tracing.sampleRate Fix type of tracing.sampleRate Feb 13, 2026
@mloiseleur mloiseleur changed the title Fix type of tracing.sampleRate Fix type of tracing.sampleRate Feb 13, 2026
@diofeher diofeher changed the title Fix type of tracing.sampleRate fix: type of tracing.sampleRate Feb 19, 2026
@diofeher
Copy link
Author

It seems when the field is null along with number, they're rendered as "string". It seems to be a limitation on helm-docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants