fix(chart): port value for websecure Gateway listener in the traefik chart#1673
Open
falzm wants to merge 1 commit intotraefik:masterfrom
Open
fix(chart): port value for websecure Gateway listener in the traefik chart#1673falzm wants to merge 1 commit intotraefik:masterfrom
websecure Gateway listener in the traefik chart#1673falzm wants to merge 1 commit intotraefik:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change fixes an error when trying to use the pre-set
websecurelistener in thetraefikchart values. Apparently, there is a known issue issue withgo-yamldeserializing numbers intofloat64instead ofint64, and the usual workaround is to cast it manually to aninttype.I've also updated the JSON Schema to actually include support for the
gateway.listeners.websecureobject in addition togateway.listeners.web, as it was previously missing – probably related to the fact that this value is optional and disabled by default, however the schema should include it anyway.Motivation
Currently, trying to use the pre-set
websecureGateway listener results in this error:With this fix, the
Gatewayresource is correctly rendered:More
make testand all the tests passed