Skip to content

fix(traefik-hub): set token using a file#1679

Open
komalsukhani wants to merge 12 commits intotraefik:masterfrom
komalsukhani:feat/add-new-token-config
Open

fix(traefik-hub): set token using a file#1679
komalsukhani wants to merge 12 commits intotraefik:masterfrom
komalsukhani:feat/add-new-token-config

Conversation

@komalsukhani
Copy link
Copy Markdown

@komalsukhani komalsukhani commented Feb 23, 2026

What does this PR do?

Added following new configuration options in traefik chart to allow setting of token using file:

  • tokenMountPath:
    Token k8s secret will be mounted as volume on this path. Set to /etc/secrets by default.

Motivation

Security. Allows to avoid exposing the token in an env variable of the container.

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

@komalsukhani komalsukhani changed the title Add new configuration fields to allow user to set token using a file Feat: Add new configuration fields to allow user to set token using a file Feb 23, 2026
@komalsukhani komalsukhani changed the title Feat: Add new configuration fields to allow user to set token using a file feat: Add new configuration fields to allow user to set token using a file Feb 23, 2026
@mloiseleur mloiseleur changed the title feat: Add new configuration fields to allow user to set token using a file feat(traefik-hub): allow user to set token using a file Feb 23, 2026
Copy link
Copy Markdown
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the related traefik-hub PR.

@mloiseleur mloiseleur changed the title feat(traefik-hub): allow user to set token using a file fix(traefik-hub): set token using a file Mar 4, 2026
@mloiseleur
Copy link
Copy Markdown
Member

@komalsukhani Since this option will only be available in v3.19.3+, wdyt of updating the requirements here?
https://github.com/traefik/traefik-helm-chart/blob/master/traefik/templates/requirements.yaml#L121

@komalsukhani
Copy link
Copy Markdown
Author

@komalsukhani komalsukhani force-pushed the feat/add-new-token-config branch from 12d3a6b to a486fa3 Compare March 5, 2026 08:51
@komalsukhani komalsukhani force-pushed the feat/add-new-token-config branch from a486fa3 to 9045995 Compare March 5, 2026 10:16
Copy link
Copy Markdown
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot/no-merge kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants