fix: correctly resolve fields of aliased structs#1679
Merged
mvertes merged 3 commits intotraefik:masterfrom Jan 8, 2025
Merged
fix: correctly resolve fields of aliased structs#1679mvertes merged 3 commits intotraefik:masterfrom
mvertes merged 3 commits intotraefik:masterfrom
Conversation
Bai-Yingjie
pushed a commit
to godevsig/yaegi
that referenced
this pull request
Jun 9, 2025
Co-authored-by: Marc Vertes <mvertes@free.fr>
rcoreilly
pushed a commit
to cogentcore/yaegi
that referenced
this pull request
Jun 21, 2025
Co-authored-by: Marc Vertes <mvertes@free.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fields of types that are aliases are not always resolved correctly, especially if the aliased type is itself an alias.
A minimal example is:
There is already a method (
baseType) for resolving the underlying struct type; but it isn't always used previous to this change.