Various bugfixes for the gtfsToTimetableApi example code#11
Open
hallonstedt wants to merge 5 commits intotrafiklab:masterfrom
Open
Various bugfixes for the gtfsToTimetableApi example code#11hallonstedt wants to merge 5 commits intotrafiklab:masterfrom
hallonstedt wants to merge 5 commits intotrafiklab:masterfrom
Conversation
Contributor
hallonstedt
commented
Sep 11, 2024
- Update README with valid links to how API-keys are created
- Update requirements.txt to allow for more modern versions of libraries needed. I have tested them and they work fine.
- Add window start and end to the query_engine calls since default arguments only evaluate when the function is defined which previously meant that the departure window was static.
- The static time-table files were only loaded on application start instead of every 24 hours as intended. They are now checked on ever end-point call and if expired, they will be updated. This means a few milliseconds additional delay to API-calls but should not be noticeable.
- if GtfsTimeTable.py is run directly, it didn't use the command-line provided stop_id. This is now fixed.
…nd all work well without code changes.
…ted when the function is defined so updated time windows needs to be sent on every request
…check if it needs to be updated on every endpoint connect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.