Modernize gem #50
Open
Modernize gem #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use hirber instead of hirb, the later did not get an update for 1 decade
There was a problem hiding this comment.
Pull Request Overview
This PR updates the gem to use the maintained dependency “hirber” instead of “hirb” and modernizes the codebase by adding frozen string literal comments and updating related configurations.
- Replace deprecated “hirb” with “hirber” in the presentation layer
- Introduce frozen string literal comments across multiple files
- Update CI workflow and Gemfile dependencies to support newer Ruby versions and tools
Reviewed Changes
Copilot reviewed 20 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/trailblazer/developer/version.rb | Added frozen string literal comment |
| lib/trailblazer/developer/trace/* | Added frozen string literal comments across modules |
| lib/trailblazer/developer/trace/present.rb | Replaced “hirb” with “hirber” and added frozen string literal |
| Gemfile | Added Rubocop and updated frozen string literal comment |
| .github/workflows/ci.yml | Updated Ruby version matrix and checkout action version |
Comments suppressed due to low confidence (1)
lib/trailblazer/developer/trace/present.rb:2
- Please ensure that the new dependency 'hirber' is added to the gemspec or Gemfile and is compatible with existing code, replacing the deprecated 'hirb'.
require "hirber"
Member
|
Please, please, please, one feature per PR. We don't need the frozen_string across all files. 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use hirber instead of hirb, the later did not get an update for 1 decade
closes #49