Skip to content

added custom outputs binary state methods #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
elShiaLabeouf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added custom outputs binary state methods #64

elShiaLabeouf wants to merge 1 commit into from

Conversation

@elShiaLabeouf
Copy link

@elShiaLabeouf elShiaLabeouf commented Jul 5, 2023

Please see Issue#63

@elShiaLabeouf elShiaLabeouf force-pushed the feature/custom-output-helpers branch from 3e527c5 to 9b326b7 Compare July 5, 2023 22:27
@elShiaLabeouf elShiaLabeouf mentioned this pull request Jul 5, 2023
Open
@apotonick
Copy link
Member

apotonick commented Jul 6, 2023

Two problems here:

  1. You're changing Result's public API! 😬
  2. The activity argument couples Result strongly to Activity.

Why don't you simply add a module (so your behavior is optional) that monkey-patches Result and, if called with semantic_name? checks if signal's :semantic field matches? Much easier, right?

But at least you know a lot more about the Activity API now!!! 👏 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elShiaLabeouf @apotonick