Skip to content

fix: flow test and flow SFCA fixes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muenzpraeger merged 4 commits into from
Dec 9, 2025
Merged

fix: flow test and flow SFCA fixes #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7f873d
fix: restored broken GenerateReport flow test
pozil Dec 9, 2025
377fce7
fix: restored Flow SFCA tests with bug workaround
pozil Dec 9, 2025
a07c242
Merge branch 'main' into pozil/flow-fixes
pozil Dec 9, 2025
77d8deb
ci: restrict code analyzer to current recipes
pozil Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
id: run-code-analyzer
uses: forcedotcom/run-code-analyzer@v2
with:
run-arguments: --workspace "force-app/**" --view detail --output-file "sca-results.csv" --config-file "code-analyzer.yml"
run-arguments: --workspace "force-app/main" --view detail --output-file "sca-results.csv" --config-file "code-analyzer.yml"
results-artifact-name: code-analyzer-results
github-token: ${{ github.token }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
id: run-code-analyzer
uses: forcedotcom/run-code-analyzer@v2
with:
run-arguments: --workspace "force-app/**" --view detail --output-file "sca-results.csv" --config-file "code-analyzer.yml"
run-arguments: --workspace "force-app/main" --view detail --output-file "sca-results.csv" --config-file "code-analyzer.yml"
results-artifact-name: code-analyzer-results
github-token: ${{ github.token }}

Expand Down
10 changes: 8 additions & 2 deletions code-analyzer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
engines:
rules:
flow:
disable_engine: true
# Disabled HardCodedId rule for flow as a temporary workaround for
# https://github.com/forcedotcom/code-analyzer/issues/1947
HardCodedId:
severity: Critical
tags: []

engines:
eslint:
auto_discover_eslint_config: true
disable_javascript_base_config: true
Expand Down
6 changes: 4 additions & 2 deletions ...onConfiguration/actionDescriptionOverrides/classes/ActionDescriptionOverridesFlowTest.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,11 @@ private class ActionDescriptionOverridesFlowTest {
// Set input variables for the flow
Map<String, Object> inputs = new Map<String, Object>();
inputs.put('report_type', 'Sales Report');
inputs.put('start_date', Date.newInstance(2024, 1, 1));
inputs.put('end_date', Date.newInstance(2024, 12, 31));
inputs.put('include_charts', true);
inputs.put('user_id', UserInfo.getUserId());
inputs.put('format', 'PDF');
inputs.put('start_date', '2024-01-01');
inputs.put('end_date', '2024-12-31');

// Run the flow
Test.startTest();
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"url": "git+https://github.com/trailheadapps/agent-script-recipes"
},
"scripts": {
"code-analyzer": "sf code-analyzer run --workspace force-app/main --view detail --output-file \"sca-results.csv\" --config-file \"code-analyzer.yml\"",
"lint": "eslint .",
"test": "npm run test:unit",
"test:unit": "sfdx-lwc-jest",
Expand Down