Refactor validation exceptions#691
Open
sonalguptaabd-bit wants to merge 2 commits intotrailheadapps:mainfrom
Open
Refactor validation exceptions#691sonalguptaabd-bit wants to merge 2 commits intotrailheadapps:mainfrom
sonalguptaabd-bit wants to merge 2 commits intotrailheadapps:mainfrom
Conversation
|
Hey @sonalguptaabd-bit, thank you for your contributions! As a good open-source practice I recommend to first create issues around to be proposed changes, so that the maintainers can discuss those first. |
Author
|
Hi @muenzpraeger, thanks for the suggestion. I’ve opened an issue to document and discuss this refactor approach so it can be reviewed first as recommended. Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
OpportunityValidationException)instead of
addErrorfor better separation of concerns.OpportunityTriggerHandlerto handle exceptions and display proper error messages.Testing
Before
opp.addErrordirectly inside service class.After
addErrorfor user-friendly messages.