-
Notifications
You must be signed in to change notification settings - Fork 4
chore: migrate type checking to ty #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add ty>=0.0.14 to lint dependencies - Remove unreachable type: ignore comments in base.py (ty handles narrowing) - Update test_verify.py to use ty: ignore syntax for pretend stubs Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Lint seems to still be failing |
0adcc81 to
b5cbfde
Compare
|
CI was failing because Interesting, I was ready to write that it was because I was running Python 3.12 on my laptop, and 3.14 on the CI, and my local tests with 3.14 (using |
Looks like [tool.mypy]
mypy_path = "src" |
Good catch! |
Co-authored-by: Facundo Tuesca <[email protected]>
This reverts commit b3b7df6.
I've tried to remove our usage of
mypyto usety.We just have some warnings when using stubs in our tests because they don't match the expected type, but I think that's expected.