Skip to content

fix(gh-cli): exit 0 when CLAUDE_ENV_FILE is unset #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmaynor wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix(gh-cli): exit 0 when CLAUDE_ENV_FILE is unset #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/gh-cli/hooks/setup-shims.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ fi
# Guard: CLAUDE_ENV_FILE must be set by the runtime
if [[ -z "${CLAUDE_ENV_FILE:-}" ]]; then
echo "gh-cli: CLAUDE_ENV_FILE not set; shims will not be installed" >&2
exit 1
exit 0
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this guard to exit 0 will require updating the existing bats test that currently asserts a non-zero exit status when CLAUDE_ENV_FILE is unset (plugins/gh-cli/hooks/setup-shims.bats, test "exits with error when CLAUDE_ENV_FILE is not set"). As-is, CI will fail because the test expects status 1 but the script now returns 0.

Suggested change
exit 0
exit 1

Copilot uses AI. Check for mistakes.
fi

shims_dir="$(cd "$(dirname "$0")/shims" && pwd)" || {
Expand Down
Loading