-
Notifications
You must be signed in to change notification settings - Fork 17
Codeql install updates #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
fegge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I added a few language recommendation. Nothing big.
|
Can we get this merged? |
|
ping |
| of the version you want, you can use `"*"` which always resolves to the latest | ||
| version.) | ||
|
|
||
| ### Installing the new packs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this step still necessary if you've properly set up your workspace with codeql-workspace.yml?
I ask because I've had some trouble between using codeql-workspace.yml vs. .codeqlmanifest.json vs. --search-path vs. --additional-packs. And generally just using codeql-workspace.yml has fixed my problems 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure? You need codeql to known the location somehow, would it auto-pick locally cloned repo?
Also the pack download is easier than cloning the repo.
Fell free to update this section anyway.
Add more information about installing and unit-testing custom codeql rules.
One link is now broken, but will the upstream file will be crated soon.