Skip to content

Conversation

@frabert
Copy link
Contributor

@frabert frabert commented Jan 27, 2025

Known issues:

  • The conversion pass uses a shared_ptr to the server in order to allow the pass to be cloneable -- it's not super elegant
  • This currently asks the user for a lot of information about functions

@frabert frabert force-pushed the frabert/server branch 5 times, most recently from 63106ed to 3d2f75d Compare January 27, 2025 13:43
@frabert frabert changed the title Frabert/server Add option to start interactive server for Parser dialect conversion Jan 27, 2025
@frabert frabert marked this pull request as ready for review January 27, 2025 14:10
@frabert frabert requested a review from xlauko as a code owner January 27, 2025 14:10
@frabert frabert force-pushed the frabert/server branch 2 times, most recently from 52492b7 to e6298fb Compare January 31, 2025 11:26
@github-actions
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v19.1.1) reports: 1 file(s) not formatted
  • lib/vast/Conversion/Parser/ToParser.cpp
clang-tidy (v19.1.1) reports: 1 concern(s)
  • include/vast/Conversion/Parser/Passes.hpp:22:14: error: [clang-diagnostic-error]

    'vast/Conversion/Parser/Passes.h.inc' file not found

       22 |     #include "vast/Conversion/Parser/Passes.h.inc"
          |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

@xlauko xlauko merged commit 8489176 into master Mar 26, 2025
8 checks passed
@xlauko xlauko deleted the frabert/server branch March 26, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants