Skip to content

pr: Emit maybeparse operations in SARIF files #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xlauko merged 1 commit into from
Apr 16, 2025
Merged

pr: Emit maybeparse operations in SARIF files #786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tools/vast-detect-parsers/ParserCategoryDetector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2024, Trail of Bits, Inc.

Check notice on line 1 in tools/vast-detect-parsers/ParserCategoryDetector.cpp

View workflow job for this annotation

GitHub Actions / cpp-linter (19, 22.04)

Run clang-format on tools/vast-detect-parsers/ParserCategoryDetector.cpp 

File tools/vast-detect-parsers/ParserCategoryDetector.cpp does not conform to Custom style guidelines. (lines 74, 75)

#ifdef VAST_ENABLE_SARIF
#include "SarifPasses.hpp"
Expand Down Expand Up @@ -64,6 +64,25 @@
}
results.push_back(result);
});

getOperation().walk([&](pr::MaybeParse op) {
gap::sarif::result result{
.ruleId{ "pr-maybeparse" },
.ruleIndex = 0,
.kind = gap::sarif::kind::kInformational,
.level = gap::sarif::level::kNote,
.message{
.text{ { "Potential parsing operation detected" } },
},
.locations{},
};
if (auto loc = cc::sarif::mk_location(op.getLoc());
loc.physicalLocation.has_value())
{
result.locations.push_back(std::move(loc));
}
results.push_back(result);
});
}
} // namespace vast
#endif