Skip to content

Conversation

@BuffaloWill
Copy link
Contributor

Adds new "Add Region to a Finding with Label" (#71) command that prompts for a label when adding a region to an existing finding.

Use case: a user wants to label a code selection (region) with a custom note (label) and add it to an existing finding

Test plan

  • Select a region of code in the editor
  • Run "weAudit: Add Region to a Finding with Label" from the command palette
  • Select an existing finding from the picker
  • Enter a label for the location
  • Verify the region is added to the finding with the label displayed
CleanShot.2025-11-25.at.09.26.20.mp4

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2025

CLA assistant check
All committers have signed the CLA.

dariushoule
dariushoule previously approved these changes Nov 25, 2025
Copy link
Contributor

@dariushoule dariushoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked as advertised in both list and tree views. Also tried some edge-cases like multi-select and empty label. Seems to work like I'd expect there too.

🎉

@fcasal
Copy link
Collaborator

fcasal commented Dec 22, 2025

@BuffaloWill Since this feature is unlikely to deviate much from the similar "Add Region to a Finding" command, it would be nice to unify the implementations to reduce code duplication. Do you mind if I push something that does this?

@BuffaloWill
Copy link
Contributor Author

@BuffaloWill Since this feature is unlikely to deviate much from the similar "Add Region to a Finding" command, it would be nice to unify the implementations to reduce code duplication. Do you mind if I push something that does this?

Sounds good. Thanks @fcasal

@fcasal fcasal force-pushed the issue-71-add-region-finding-label branch from f02fbba to 69155f9 Compare December 22, 2025 17:35
Copy link
Collaborator

@fcasal fcasal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fcasal fcasal merged commit 202e630 into main Dec 22, 2025
5 of 6 checks passed
@fcasal fcasal deleted the issue-71-add-region-finding-label branch December 22, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants