fix: Update session handling to use a consistent session name#23
Merged
fix: Update session handling to use a consistent session name#23
Conversation
…GitHub and Google handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request standardizes the session name used across authentication handlers and middleware by replacing the use of a configurable
sessionSecretwith the hardcoded string"trakrlog-session". This ensures consistent session management and simplifies session retrieval throughout the codebase.Authentication session handling:
GitHubHandler.HandleCallbackto use"trakrlog-session"instead of the variableh.sessionSecret.GoogleHandler.HandleCallbackandGoogleHandler.GetAuthUserto use"trakrlog-session"instead ofh.sessionSecret. [1] [2]Middleware session retrieval:
RequireAuthmiddleware inauth.goto use"trakrlog-session"for session retrieval instead of the passedsessionSecretparameter.…GitHub and Google handlersType of Change
Related Issue
Closes #(issue number)
How Has This Been Tested?
Describe the tests you ran and how to reproduce them.
Screenshots (if applicable)
Add screenshots to help explain your changes.
Checklist