update createDefaultCodec to handle object types correctly#34
Merged
abrantesarthur merged 3 commits intomainfrom Jan 19, 2025
Merged
update createDefaultCodec to handle object types correctly#34abrantesarthur merged 3 commits intomainfrom
abrantesarthur merged 3 commits intomainfrom
Conversation
dipack95
reviewed
Jan 19, 2025
|
|
||
| // The default of an object type is an empty object | ||
| if (codec instanceof t.ObjectType) { | ||
| return {} as t.TypeOf<C>; |
Member
There was a problem hiding this comment.
Would be useful to do this for t.UnknownRecord too since t.object is deprecated
dipack95
approved these changes
Jan 19, 2025
| it('should correctly build a default codec for an object', () => { | ||
| const codec = t.object; | ||
| const defaultCodec = createDefaultCodec(codec); | ||
| expect(defaultCodec).to.deep.equal({}); |
Member
There was a problem hiding this comment.
Does this also enforce that there are no keys in the resulting object?
Contributor
Author
There was a problem hiding this comment.
Yes! The test fails if the object has any keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createDefaultCodecreturned null for object types. Now, it returns an empty object.