Moved /job routes in train.py to /experiment/jobs.py

[ParamThakkar123]

Fixes transformerlab/transformerlab-app#725

[codecov]

Codecov Report

❌ Patch coverage is 26.08696% with 34 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
transformerlab/routers/experiment/jobs.py	26.08%	33 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[dadmobile]

Is there a corresponding frontend PR that changes the app to use these routes in their new location?

[ParamThakkar123]

Is there a corresponding frontend PR that changes the app to use these routes in their new location?

I haven't started a PR on the frontend yet

[dadmobile]

Maybe for now we should set this to draft or "[WIP]". I don't think we can merge until frontend is updated at the same time.

I was worried that this might not be possible because I thought we had a page on frontend where you could view jobs from outside the scope of an experiment...but I looked at ViewJobsTav.tsx and looks like it should be OK!

[dadmobile]

Maybe for now we should set this to draft or "[WIP]". I don't think we can merge until frontend is updated at the same time.

I was worried that this might not be possible because I thought we had a page on frontend where you could view jobs from outside the scope of an experiment...but I looked at ViewJobsTav.tsx and looks like it should be OK!

Oh never mind. I just saw your PR on the app! Sorry!

[ParamThakkar123]

Oh. Sorry I forgot to mention the frontend PR here, if we require any changes on the PR on frontend, will make that change and possibly we can get this merged today ?

[deep1401]

Oh. Sorry I forgot to mention the frontend PR here, if we require any changes on the PR on frontend, will make that change and possibly we can get this merged today ?

Will test this out!
Just a helpful practice I use is that whenever I have connected PRs, I mention a comment Depends on transformerlab/transformerlab-api#<PR number> on the frontend so Github shows them to be connected! :)

[deep1401]

Awaiting frontend changes on this one and then will approve this one so we merge both together

[dadmobile]

(Otherwise everything looks good)

[deep1401]

Awaiting frontend changes on this one and then will approve this one so we merge both together

I approved the frontend from my side. I think Tony still might need to do an approval as he also requested changes. You might want to fix the failing test on here? I think its because of the changed route now

[ParamThakkar123]

@dadmobile @deep1401 Tests passed!