-
Notifications
You must be signed in to change notification settings - Fork 43
Fixed Terminal error if you try to import models and don't have Ollama installed #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
dadmobile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe explain to me what was happening and what you changed? I don't quite get this one but it would good to get this error fixed!
For this issue the api was giving the following error in the terminal everytime we import a model, even if ollama is not installed. The app is trying to look for ollama models even if you don't have Ollama installed when you click on Import Models in the Model Zoo. The try catch probably doesn't account for this case or maybe it does but still gives this error |
…ab-api into fix/fix-no-ollama-but-still-ollama
dadmobile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK no wait I take back my approval. I don't have OLLAMA_MODELS set in my environment and I have Ollama installed! I think we need a different thing to check for?
I'm not sure of the best way. Maybe check if shutil.which("ollama") isn't None?
Or do the thing Deep said and catch the specific error? I'm not sure which is better but this one doesn't work for me.
…ab-api into fix/fix-no-ollama-but-still-ollama
…om/transformerlab/transformerlab-api into fix/fix-no-ollama-but-still-ollama
|
Sure I will delete it |
…ab-api into fix/fix-no-ollama-but-still-ollama
…om/transformerlab/transformerlab-api into fix/fix-no-ollama-but-still-ollama
deep1401
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on my end as the change I requested was added
|
@dadmobile to approve |
Fixes transformerlab/transformerlab-app#352