Fix audio mlx server connect error #1057
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| lang_code = params.get("lang_code", None) | ||
| stream = params.get("stream", False) | ||
|
|
||
| experiment_dir = get_experiments_dir() |
There was a problem hiding this comment.
Just a suggestion but I think this doesnt work because the lab context getting set when this file runs is not passed on to the uvicorn app that runs from this. I do set a lab context so the get_experiments_dir should've worked if it was running directly in this file. Do you think a better approach would be passing in experiments dir through the main() function by calling this function there? Or does that not work?
I'm just concerned if plugin_harness did not set the context correctly for this case and was wanting to get to the core of the issue
dadmobile
left a comment
dadmobile
left a comment
There was a problem hiding this comment.
Approving for now. There are two bugs still but I will file separate tickets for those:
- it keeps creating output_audio.wav and overwriting the last generated file
- downloads come with a .mp3 filename but are actually a .wav
No description provided.