Suggest a compatible loader plugin for when one is not installed and a model is selected #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadmobile
requested changes
Jan 2, 2026
src/renderer/components/Experiment/Foundation/RunModelButton.tsx
Outdated
Show resolved
Hide resolved
src/renderer/components/Experiment/Foundation/RunModelButton.tsx
Outdated
Show resolved
Hide resolved
…ab-app into fix/run-button-compatible-message
…m/transformerlab/transformerlab-app into fix/run-button-compatible-message
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
dadmobile
reviewed
Jan 2, 2026
| }, [data, supportedEngines]); | ||
|
|
||
| // Use the suggested loader plugin from API (platform-aware) | ||
| const compatibleLoaderPlugins = suggestedLoaderPlugin |
Member
There was a problem hiding this comment.
Nitpick: Probably don't need to create and convert this to an array just to call [0] on it later?
Member
Author
There was a problem hiding this comment.
I kept it as an array so we can show more of them later on if we wanted and change the messaging. And it also helped with the length condition. Should I not do that and just return the first one and check for a blank string then?
Member
There was a problem hiding this comment.
Yeah I htink with the change to just get a single suggestion from the backend it makes more sense to get rid of the array for now.
dadmobile
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1020