Skip to content

Conversation

@ParamThakkar123
Copy link

No description provided.

Copy link
Member

@deep1401 deep1401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks to ensure script is using latest lab-sdk

Copy link
Member

@deep1401 deep1401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try this out in sometime. But a general comment would be adding "parameters" to task.json since we are using lab.get_config in the script but this is not compulsory for this PR and I can do this separately since none of the other ones are using parameters right now

Copy link
Member

@deep1401 deep1401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works, just had a bug while running but thats one install package missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants